Comments on: Introducing Malicious Code Reviews http://blog.paulbiggar.com/archive/introducing-malicious-code-reviews/ Compilers, open source, and similar. Wed, 13 Jul 2011 21:03:00 +0000 hourly 1 http://wordpress.org/?v=3.3.1 By: Joe http://blog.paulbiggar.com/archive/introducing-malicious-code-reviews/#comment-6 Joe Wed, 28 Jan 2009 17:37:00 +0000 http://blog.paulbiggar.com/?p=7#comment-6 Shame is a motivator. <br/><br/>Where you read about build discipline, you often find mention of the "shame email" that goes out to all devs when a commit breaks the build.<br/><br/>So, call it retaliation ... or shame ... this has to occur, if we want better code. Shame is a motivator.

Where you read about build discipline, you often find mention of the “shame email” that goes out to all devs when a commit breaks the build.

So, call it retaliation … or shame … this has to occur, if we want better code.

]]> By: Joe http://blog.paulbiggar.com/archive/introducing-malicious-code-reviews/#comment-212 Joe Wed, 28 Jan 2009 17:37:00 +0000 http://blog.paulbiggar.com/?p=7#comment-212 Shame is a motivator. Where you read about build discipline, you often find mention of the "shame email" that goes out to all devs when a commit breaks the build.So, call it retaliation ... or shame ... this has to occur, if we want better code. Shame is a motivator. Where you read about build discipline, you often find mention of the “shame email” that goes out to all devs when a commit breaks the build.So, call it retaliation … or shame … this has to occur, if we want better code.

]]> By: Anonymous http://blog.paulbiggar.com/archive/introducing-malicious-code-reviews/#comment-5 Anonymous Tue, 27 Jan 2009 03:11:00 +0000 http://blog.paulbiggar.com/?p=7#comment-5 Beware the malicious malicious-code-review review that will demonstrate "why your malicious review system is rotten from the ground up". Beware the malicious malicious-code-review review that will demonstrate “why your malicious review system is rotten from the ground up”.

]]> By: Anonymous http://blog.paulbiggar.com/archive/introducing-malicious-code-reviews/#comment-211 Anonymous Tue, 27 Jan 2009 03:11:00 +0000 http://blog.paulbiggar.com/?p=7#comment-211 Beware the malicious malicious-code-review review that will demonstrate "why your malicious review system is rotten from the ground up". Beware the malicious malicious-code-review review that will demonstrate “why your malicious review system is rotten from the ground up”.

]]> By: toxik http://blog.paulbiggar.com/archive/introducing-malicious-code-reviews/#comment-4 toxik Tue, 27 Jan 2009 00:26:00 +0000 http://blog.paulbiggar.com/?p=7#comment-4 Good god, the mind boggles.<br/><br/>The thing is full of premature optimizations. Like static inlines in headers, overridden tolower functions, and...<br/><br/>Anyway, just dropping a line to tell you about my very own PHP rant, which is about the PHP language in general: http://b.lericson.se/~toxik/php_sucks_rant.log Good god, the mind boggles.

The thing is full of premature optimizations. Like static inlines in headers, overridden tolower functions, and…

Anyway, just dropping a line to tell you about my very own PHP rant, which is about the PHP language in general: http://b.lericson.se/~toxik/php_sucks_rant.log

]]> By: toxik http://blog.paulbiggar.com/archive/introducing-malicious-code-reviews/#comment-210 toxik Tue, 27 Jan 2009 00:26:00 +0000 http://blog.paulbiggar.com/?p=7#comment-210 Good god, the mind boggles.The thing is full of premature optimizations. Like static inlines in headers, overridden tolower functions, and...Anyway, just dropping a line to tell you about my very own PHP rant, which is about the PHP language in general: http://b.lericson.se/~toxik/php_sucks_rant.log Good god, the mind boggles.The thing is full of premature optimizations. Like static inlines in headers, overridden tolower functions, and…Anyway, just dropping a line to tell you about my very own PHP rant, which is about the PHP language in general: http://b.lericson.se/~toxik/php_sucks_rant.log

]]> By: Paul Biggar http://blog.paulbiggar.com/archive/introducing-malicious-code-reviews/#comment-3 Paul Biggar Mon, 26 Jan 2009 23:38:00 +0000 http://blog.paulbiggar.com/?p=7#comment-3 - John<br/><br/>The 'retaliation' part is largely rhetoric, so don't worry :)<br/><br/>I won't be submitting patches, and I'll explain why. These code reviews (I intend to write a few more) are meant to demonstrate that PHP is rotten from the ground up. While some of the flaws here could be patched, the majority of the problems are endemic in the code, the language, and the community. More to come. - John

The ‘retaliation’ part is largely rhetoric, so don’t worry :)

I won’t be submitting patches, and I’ll explain why. These code reviews (I intend to write a few more) are meant to demonstrate that PHP is rotten from the ground up. While some of the flaws here could be patched, the majority of the problems are endemic in the code, the language, and the community. More to come.

]]> By: Paul Biggar http://blog.paulbiggar.com/archive/introducing-malicious-code-reviews/#comment-209 Paul Biggar Mon, 26 Jan 2009 23:38:00 +0000 http://blog.paulbiggar.com/?p=7#comment-209 - JohnThe 'retaliation' part is largely rhetoric, so don't worry :)I won't be submitting patches, and I'll explain why. These code reviews (I intend to write a few more) are meant to demonstrate that PHP is rotten from the ground up. While some of the flaws here could be patched, the majority of the problems are endemic in the code, the language, and the community. More to come. - JohnThe ‘retaliation’ part is largely rhetoric, so don’t worry :)I won’t be submitting patches, and I’ll explain why. These code reviews (I intend to write a few more) are meant to demonstrate that PHP is rotten from the ground up. While some of the flaws here could be patched, the majority of the problems are endemic in the code, the language, and the community. More to come.

]]> By: John Herren http://blog.paulbiggar.com/archive/introducing-malicious-code-reviews/#comment-2 John Herren Mon, 26 Jan 2009 22:30:00 +0000 http://blog.paulbiggar.com/?p=7#comment-2 While it's unfortunate that your stated motive is retaliation, I think it's appreciated that you'd take the time to make PHP better through your commentary, for what it's worth. Will you be submitting patches? While it’s unfortunate that your stated motive is retaliation, I think it’s appreciated that you’d take the time to make PHP better through your commentary, for what it’s worth. Will you be submitting patches?

]]> By: John Herren http://blog.paulbiggar.com/archive/introducing-malicious-code-reviews/#comment-208 John Herren Mon, 26 Jan 2009 22:30:00 +0000 http://blog.paulbiggar.com/?p=7#comment-208 While it's unfortunate that your stated motive is retaliation, I think it's appreciated that you'd take the time to make PHP better through your commentary, for what it's worth. Will you be submitting patches? While it’s unfortunate that your stated motive is retaliation, I think it’s appreciated that you’d take the time to make PHP better through your commentary, for what it’s worth. Will you be submitting patches?

]]>