Tag Archives: phc

Great commit messages

roc and jimb write great commit messages. As well as fulfilling the basics requirements of listing the reviewer, bug number, etc, they add enough context that you don’t need to crawl through bugzilla to get a reasonable understanding of the … Continue reading

Posted in Uncategorized | Tagged , , , , , , , | Comments Off

A rant about PHP compilers in general and HipHop in particular.

I’ve worked on phc since 2005, and been its maintainer since 2007. I wrote the optimizer, and nearly everything performance related. I had mixed reactions upon hearing about the release of HPHP [1], the new PHP compiler from Facebook. There … Continue reading

Posted in Uncategorized | Tagged , , , , , , , , , , , , , , , , , , | 22 Comments

Introducing Malicious Code Reviews

I’m inventing a new sport today, which I call “malicious code reviews”. I spent a few hours reading some really very bad code, and in retaliation against its author(s), I’m going to code review it [1]. The code comes from … Continue reading

Posted in Uncategorized | Tagged , , , , , , , | 10 Comments